Merged
Conversation
Signed-off-by: Yanxuan Liu <yanxuanl@nvidia.com>
Signed-off-by: Yanxuan Liu <yanxuanl@nvidia.com>
pxLi
approved these changes
Aug 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhances the markdown link check GitHub action by adding support for all available parameters from the underlying tcort/github-action-markdown-link-check action. This change makes the shared action more flexible and configurable for different use cases.
- Adds comprehensive input parameters for markdown link checking configuration
- Replaces hardcoded values with configurable inputs and appropriate defaults
- Updates the workflow to demonstrate usage of the new input parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| markdown-link-check/action.yml | Adds input parameters and replaces hardcoded values with configurable inputs |
| .github/workflows/markdown-link-check.yml | Demonstrates usage of new input parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| required: false | ||
| base-branch: | ||
| description: 'Comparison branch for modified files check' | ||
| required: false |
There was a problem hiding this comment.
The base-branch parameter was previously hardcoded to 'gh-pages' but now has no default value. Consider adding a default value or documenting the expected behavior when this parameter is not provided.
Suggested change
| required: false | |
| required: false | |
| default: 'gh-pages' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #48
Support all parameters of https://github.com/tcort/github-action-markdown-link-check?tab=readme-ov-file#custom-variables for shared action.
Test log: https://github.com/YanxuanLiu/spark-rapids-common/actions/runs/17061831171/job/48370058150?pr=5#step:4:9